Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAAS-33539: Add nil check in the builtin_date.go #126

Merged
merged 1 commit into from
Oct 7, 2024
Merged

BAAS-33539: Add nil check in the builtin_date.go #126

merged 1 commit into from
Oct 7, 2024

Conversation

LijieZhang1998
Copy link

I repro this panic when the call argument equals to FunctionCall{ctx: r.vm.ctx, Arguments: []Value{nil}} in the _intArg function.

kpatel71716
kpatel71716 approved these changes Oct 4, 2024
View reviewed changes
Copy link

@kpatel71716 kpatel71716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gabri3l
Gabri3l approved these changes Oct 7, 2024
View reviewed changes
Copy link

@Gabri3l Gabri3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@LijieZhang1998 LijieZhang1998 merged commit 476c6e0 into mongodb-forks:realm Oct 7, 2024
2 of 6 checks passed
@LijieZhang1998 LijieZhang1998 deleted the baas-33539 branch October 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatel71716 kpatel71716 kpatel71716 approved these changes

@Gabri3l Gabri3l Gabri3l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LijieZhang1998 @Gabri3l @kpatel71716