BAAS-32412: add nil check in mem usage for key and item in builtin_set #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabri3l
commented
Jun 26, 2024
Comment on lines
-367
to
-369
| // We still want to account for both key and value if we return a non-zero value on error. | ||
| // This could otherwise skew the estimate when in reality key/value pairs contribute to | ||
| // mem usage together. |
There was a problem hiding this comment.
I removed this on purpose to align with how we normally calculate mem usage, can refactor later if we notice this being an issue but I expect it to be rare.
nathantfrank
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.