Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sample app #140

Merged
merged 2 commits into from
Oct 4, 2023
Merged

update sample app #140

merged 2 commits into from
Oct 4, 2023

Conversation

mt-dfrey
Copy link
Contributor

@mt-dfrey mt-dfrey commented Oct 3, 2023 •
edited
Loading

  • fix(sample): use new service options after re-write in 3.2.1
  • refactor(sample): inline variable, use staging, remove useless await

@mt-dfrey mt-dfrey requested a review from a team October 3, 2023 08:37
mt-matthias
mt-matthias previously approved these changes Oct 4, 2023
View reviewed changes
@mt-dfrey mt-dfrey dismissed mt-matthias’s stale review October 4, 2023 00:59

The merge-base changed after approval.

@mt-dfrey mt-dfrey requested review from mt-matthias and a team October 4, 2023 05:16
@mt-dfrey mt-dfrey mentioned this pull request Oct 4, 2023
Merged
@mt-dfrey mt-dfrey merged commit 6fc3b56 into master Oct 4, 2023
2 checks passed
@mt-dfrey mt-dfrey deleted the update-sample-app branch October 4, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-matthias mt-matthias mt-matthias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mt-dfrey @mt-matthias