-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/md 7041 publish python package #34
Conversation
I've updated classifiers according to the list of classifiers. I also preselected MIT license. We can discuss it in the IT daily if we want to choose another one. |
I thinks MIT is the best for us. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested building package locally and haven't found any problems with the package content or with the build process.
/rebase |
f13fe01
to
9e8d4ae
Compare
@felix11h Do you need more time to review this PR or can I merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for waiting for my review, @catcombo. I have approved the changes, there's nothing I see that would speak against merging as is.
I did leave some additional comments, which are in part for my own understanding. Maybe this is still something we can think and potentially update or change in a second step.
description = "" | ||
authors = [] | ||
version = "1.1+SNAPSHOT" | ||
description = "YouTrack SDK" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "YouTrack SDK" | |
description = "YouTrack API SDK" |
To make it consistent with the description of the GitHub repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that YouTrack API SDK
is the correct description. For example, boto3 is just AWS SDK for Python, not AWS API SDK. So maybe we should update repository description instead of package description.
There are 2 problems:
|
:( Okay, let's discuss it again.
We discussed this and the point from @felix11h was that CI workflow will be successful in feature branches, otherwise we can't merge to master. So it is okay to run in parallel. Otherwise, we could use the way with a composite action and add a condition, or we can check the trigger types. |
Thanks for the explanation. This makes sense. |
We've decided in the IT daily to remove local version and deploy a package. |
Added possibility to publish Python package to PyPI, see #32.
There is another PR to add the credentials: https://github.com/moneymeets/moneymeets-pulumi/pull/483, which I already applied.
We agreed on the following versioning schema:
locally:
1.1+SNAPSHOT
published:
1.0.202310461046+gabcde
The workflow can be tested by updating the branch from
master
tofeature/MD-7041-publish-python-package
inpublish.yml
.Furthermore, there is a to-do item in
pyproject.toml
. @catcombo Please clarify and update this.