Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add a ruleset powered by unicorn plugin into essentials config #335

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

wakamsha
Copy link
Contributor

@wakamsha wakamsha commented Oct 17, 2024

What changed / motivation ?

Add a ruleset powered by eslint-plugin-unicorn into essentials config.

It plugin provides over 100 rules that extend the rule concepts provided by ESLint core.

It is expected that introducing it will encourage proper use of naming conventions for variables and functions, regular expressions, and so on.

Linked PR / Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha wakamsha self-assigned this Oct 17, 2024
@wakamsha wakamsha marked this pull request as ready for review October 21, 2024 23:50
@wakamsha wakamsha marked this pull request as draft October 22, 2024 01:05
@wakamsha wakamsha marked this pull request as ready for review October 22, 2024 01:05
Copy link
Member

@taigakiyokawa taigakiyokawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆‍♂️ Thank you! I read the recommended rules overview and rules that are disabled for our config and why. I didn’t catch the details of all the rules that we will add, but roughly makes sense. Let's move on.

@wakamsha wakamsha merged commit c5a1544 into main Oct 25, 2024
3 checks passed
@wakamsha wakamsha deleted the feat/unicorn branch October 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants