Add tx_timestamp to resultset in api/outputs #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to have
tx_timestamp
added as an output from theapi/outputs
JSON API which Bisq intends to use for XMR tx proof integration.This would enable the caller to validate that the trade date is not older than expected.
Related discussion
bisq-network/bisq#4421 (comment)
Testing performed
/api/outputs?txhash=b87c96c1d7f121a3f27d5a59211de8f5f21b2a110ffa3586f91b6e21232e30e9&address=4ATyxmFGU7h3EWu5kYR6gy6iCNFCftbsjATfbuBBjsRHJM4KTwEyeiyVNNUmsfpK1kdRxs8QoPLsZanGqe1Mby43LeyWNMF&viewkey=8152a4a2fa17c66acfb91e35f1699f7252f1a66cf963fd94da3776ee09a9aa0d&txprove=1