test(utils): add unit tests for utils.rs (HashType and serde) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done @TheCharlatan |
|
wait a second, I messed up the commits |
|
done |
TheCharlatan
approved these changes
Jul 13, 2022
refring
pushed a commit
to refring/monero-rpc-rs
that referenced
this pull request
Oct 16, 2022
…-rs#59) * test(utils): add unit tests for utils.rs (HashType and serde) * docs(CHANGELOG): update changelog to reflect new tests in utils.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for
utils.rs. They are mostly simple unit tests to make sure everything is working as we expect.Also, note that
from_strforVec<u8>returns an error if the string starts with0x, while this does not happen to theo ther types.