Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tar extract cmd for systems with 16 bit uid_t #9589

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ishanarora
Copy link
Contributor

One build dependency tarball, protobuf-cpp-3.6.1.tar.gz) contains file owner uid/gid as 231664/89939. This file fails to extract during the build process with the following error on systems where either uid_t or gid_t is limited to 16 bits (e.g. older kernels, rootless containers etc) i.e. the maximum uid_t/gid_t is 65534:

tar: six.BUILD: Cannot change ownership to uid 231664, gid 89939: Invalid argument

Since the file ownership is immaterial for the build process, this PR adds the --no-same-owner flag to tar command. This fixes #8639

Copy link

@iamamyth iamamyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build process shouldn't depend on the ownership info in the tarball, so this seems like a reasonable setting irrespective of the host platform.

@luigi1111 luigi1111 merged commit aa13699 into monero-project:master Dec 23, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman Rootless Build fails
5 participants