Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: lowercase ARCH_ID #9541

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Oct 24, 2024

On Windows, CMake sets CMAKE{_HOST,}_SYSTEM_PROCESSOR to the value of the
PROCESSOR_ARCHITECTURE environment variable. On some systems it may be set to
AMD64. Lowercase it to ensure checks for "x86_64" or "amd64" work as expected.

For example: https://github.com/monero-project/monero/blob/master/src/crypto/CMakeLists.txt#L55

https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html

Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigi1111 luigi1111 merged commit 8ed1287 into monero-project:master Dec 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants