Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: protobuf: update to 29.1 #9478

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

depends: protobuf: update to 29.1 #9478

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Sep 13, 2024 •
edited
Loading

Requires #8929.

0xFFFC0000
0xFFFC0000 approved these changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about the build issue.

But code changes LGTM.

0xFFFC0000
0xFFFC0000 reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about the build issue.

But code changes LGTM.

P.S. That first "approve" was mistake. I was leaving comment and hit the "approve" by mistake. Anyway, thank you for working on this.

@tobtoht
Copy link
Contributor Author

tobtoht commented Sep 14, 2024

I am concerned about the build issue.

Yea, I will need to fix that. It doesn't happen with a newer version of GCC. I'll patch Abseil to work around the issue, since we can't really bump GCC for regular depends builds.

@0xFFFC0000
Copy link
Collaborator

I am concerned about the build issue.

Yea, I will need to fix that. It doesn't happen with a newer version of GCC. I'll patch Abseil to work around the issue, since we can't really bump GCC for regular depends builds.

Thanks a lot. If there was anything I can help, please don't hesitate to let me know :)

@tobtoht tobtoht force-pushed the depends_protobuf_28_1 branch from eb80d2d to 949dc9b Compare December 23, 2024 20:49
@tobtoht tobtoht changed the title depends: protobuf: update to 28.1 depends: protobuf: update to 29.1 Dec 23, 2024
@tobtoht tobtoht force-pushed the depends_protobuf_28_1 branch from 949dc9b to 148d73e Compare December 24, 2024 08:18
@tobtoht tobtoht mentioned this pull request Dec 24, 2024
Open
@tobtoht tobtoht force-pushed the depends_protobuf_28_1 branch from 148d73e to 3c256dc Compare December 24, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

Assignees
No one assigned
Labels
build system pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobtoht @0xFFFC0000 @selsta