Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezor: replace Python tools with CMake #9477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trezor: replace Python tools with CMake #9477

wants to merge 1 commit into from
+30 −568

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Sep 12, 2024

As a result, we can remove Python from the release build environment.

0xFFFC0000
0xFFFC0000 reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a draft. But code LGTM and very badly needed to get rid of PythonTools.

Thank you for working on this.

@tobtoht tobtoht mentioned this pull request Sep 26, 2024
Draft
@sneurlax
Copy link
Contributor

Yes PLEASE, PythonTools have been a pain point for me when poking around Trezor code. Concept ACK, code looks good

This was referenced Dec 24, 2024
Draft
Open
@tobtoht tobtoht marked this pull request as ready for review December 24, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 left review comments

@sneurlax sneurlax sneurlax approved these changes

Assignees
No one assigned
Labels
build system pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobtoht @sneurlax @0xFFFC0000 @selsta