Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove glibc backcompat #9171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Feb 13, 2024

This PR bumps the minimum required glibc version for release binaries to 2.27 from 2.17.

OS EOL date Glibc version Proposed Support (#9446)
Ubuntu 16.04 02 Apr 2021 2.23 No
Ubuntu 18.04 21 May 2023 2.27 No
Ubuntu 20.04 02 Apr 2025 2.31 Yes
Debian 9 (LTS) 01 Jul 2022 2.24 No
Debian 10 (LTS) 30 Jun 2024 2.28 Yes
Debian 11 (LTS) 31 Aug 2026 2.31 Yes

CentOS has been discontinued.

@selsta
Copy link
Collaborator

selsta commented Feb 13, 2024

What about Ubuntu 18.04, what glibc version does it use? I know it's EOL but I think it's somewhat still used.

@tobtoht
Copy link
Contributor Author

tobtoht commented Feb 13, 2024

~ docker run --rm -it ubuntu:18.04 bash
root@6be149847463:/# ldd --version
ldd (Ubuntu GLIBC 2.27-3ubuntu1.6) 2.27

@moneromooo-monero
Copy link
Collaborator

Why is it needed for #8929 ?

@tobtoht
Copy link
Contributor Author

tobtoht commented Feb 19, 2024

I went over this again and found that -DBACKCOMPAT=ON only lowers the minimum glibc to 2.17 for x86_64 builds with Gitian. At some point backcompat appears to have broken for other targets (riscv64 never supported < 2.27) and as far as I know nobody has complained.

Arch v0.18.3.1 #8929 (w/ BACKCOMPAT) #8929
x86_64 2.17 2.23 2.27
aarch64 2.23 2.23 2.27
i686 2.27 2.27 2.27
arm 2.27 2.27 2.27
riscv64 2.27 n/a 2.27

We could build #8929 with -DBACKCOMPAT=ON and this would lower the minimum glibc for x86_64 and aarch64 to 2.23 instead of 2.27, so this PR it is not strictly necessary.

However, with no supported Linux distributions using a glibc < 2.27 (or even < 2.31) by the time we branch from master it does not seem worthwhile to continue to fix and maintain the related depends patches and glibc_compat.cpp.

@moneromooo-monero
Copy link
Collaborator

Thanks (no objection to the patch)

@tobtoht tobtoht marked this pull request as ready for review February 20, 2024 22:19
@tobtoht tobtoht mentioned this pull request Feb 24, 2024
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobtoht
Copy link
Contributor Author

tobtoht commented Dec 23, 2024

backcompat is unused now that #8929 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants