wallet2: fix store_to() and change_password() [RELEASE]
#8938
+359
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffro256
changed the title
store_to() [RELEASE]store_to() and change_password() [RELEASE]
jeffro256
force-pushed
the
store_to_from_empty_18
branch
from
33023c5 to
aa673d4
Compare
jeffro256
force-pushed
the
store_to_from_empty_18
branch
from
aa673d4 to
738169b
Compare
|
@jeffro256 Can you please rebase on the release-v0.18 branch? |
Resolves monero-project#8932 and: 2. Not storing cache when new path is different from old in `store_to()` and 3. Detecting same path when new path contains entire string of old path in `store_to()` and 4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and 5. Changing your password and storing to a new file
jeffro256
force-pushed
the
store_to_from_empty_18
branch
from
738169b to
ba98269
Compare
|
Okay it is rebased now |
selsta
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8937