Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright: Update to 2023 #8698

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

mj-xmr
Copy link
Contributor

@mj-xmr mj-xmr commented Jan 2, 2023

Disclaimer for selsta:

No hidden dev fee was added to this PR.

@mj-xmr mj-xmr force-pushed the copyright-update-2023 branch from 7746899 to 0b5b42b Compare January 4, 2023 09:21
@plowsof
Copy link
Contributor

plowsof commented Jan 4, 2023

during review i found 20 files that could be added to this PR. (ive made a PR to your branch here mj-xmr#2) #8701 found them for me . otherwise lgtm

@mj-xmr
Copy link
Contributor Author

mj-xmr commented Jan 5, 2023

Good job!

@iamamyth
Copy link

iamamyth commented Jan 7, 2023

The following is not, and should not be construed as, legal advice, but I really do not understand the rationale for "change all copyright headers" PRs. At best, such bulk changes seem counterproductive, as the final year in the range of every header now reflects simply the current year (a fact totally divorced from the contents of the file), rather than the last year of significant modification (a fact related to the file itself, which, though possibly available via source code control, also reflects some author's judgment as to the materiality of a change). I also note that well-known open source projects, such as the Linux kernel (see, e.g., https://github.com/torvalds/linux/blob/master/kernel/cgroup/cgroup.c) do not follow this practice, and large companies, such as Google, also do not recommend this practice in their open source guidelines (https://opensource.google/documentation/reference/copyright). Surely polluting the repo history and spending time reviewing a change or tool for presumably legal reasons requires some affirmative legal justification, so, I ask: Has anyone received actual legal advice that such changes are productive? Or has this practice been proposed simply because others do it?

Notwithstanding the foregoing concerns, I suspect a "change all headers" tool could probably be repurposed to a "check for copyright year edits when editing a file, and warn if absent" tool, which seems maybe helpful to reviewers and contributors.

@mj-xmr
Copy link
Contributor Author

mj-xmr commented Jan 12, 2023

@iamamyth I would tend to agree with you.

I do it because of this:

(...) Or has this practice been proposed simply because others do it?

and because I saw various contributors doing the same thing at the same time, each having their own sets of updated files, undeniably increasing the review effort, so I thought to have at least just one set, while they can focus on other stuff.

@mj-xmr mj-xmr force-pushed the copyright-update-2023 branch from 7871a05 to 49d1c88 Compare January 16, 2023 11:58
Co-authored-by: plowsof <[email protected]>
extra files
@mj-xmr mj-xmr force-pushed the copyright-update-2023 branch from 49d1c88 to 5b4fea7 Compare January 16, 2023 12:00
@selsta selsta mentioned this pull request Mar 29, 2023
@luigi1111 luigi1111 merged commit 9bf06ea into monero-project:master Apr 25, 2023
@mj-xmr mj-xmr deleted the copyright-update-2023 branch April 25, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants