removed definition of refreshed bool

[cjac]

/usr/src/git/salsa/cryptocoin-team/monero/src/wallet/wallet2.cpp:3427:8: warning: variable ‘refreshed’ set but not used [-Wunused-but-set-variable]
3427 | bool refreshed = false;

Fails to build from source.

[selsta]

It should not fail to build from source due to an unused variable, unless you changed other things.

[cjac]

18:29 < cjac> selsta: the FTBFS came from particularly strict gcc flags
18:29 < cjac> this is the debian policy, so it's keeping debian from building. I
could commit this patch to debian, but I wanted to check with you
folks first.
18:30 < cjac> https://paste.debian.net/1263691/

[cjac]

patch squashed so I can offer it to debian package maintainers, should this PR not be merged

[UkoeHB]

This issue has appeared before, it is an intentional Chesterton's fence that @moneromooo-monero left in there.

[jeffro256]

See conversation started here: #8359 (comment)

[cjac]

patch offered to debian maintainers:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025965

[plowsof]

An update from the Debian maintainers: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1025927

There is no such compiler option added (-Werror?) and the package builds fine.
Please fix your build environment.

please close

[selsta]

Closing since we don't add this security flag anywhere and it seems debian also doesn't.