-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: prepare v0.18.1.0 #8470
build: prepare v0.18.1.0 #8470
Conversation
@@ -57,7 +57,7 @@ The dockrun.sh script will do everything to build the binaries. Just specify the | |||
version to build as its only argument, e.g. | |||
|
|||
```bash | |||
./dockrun.sh v0.17.3.0 | |||
./dockrun.sh v0.18.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to this file should be made after #8442 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR you linked is against master branch and this one is against release branch. I can adopt the changes from 8442 here if you prefer that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we get seth to submit that against release branch then? Pointless to do these edits redundantly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Messaged @sethforprivacy about opening #8442 on the release branch too
EDIT: think this PR takes priority and the merge conflict will be easy enough to resolve
I'll open #8442 against release branch today, sorry about that! Forgot that even doc changes need that. |
Done: #8491 |
@selsta if you'd like, you can just drop your DOCKRUN.md changes and I'll bump mine to v0.18.1.0. |
No description provided.