Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prepare v0.18.1.0 #8470

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Jul 28, 2022

No description provided.

@@ -57,7 +57,7 @@ The dockrun.sh script will do everything to build the binaries. Just specify the
version to build as its only argument, e.g.

```bash
./dockrun.sh v0.17.3.0
./dockrun.sh v0.18.1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to this file should be made after #8442 is merged.

Copy link
Collaborator Author

@selsta selsta Jul 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR you linked is against master branch and this one is against release branch. I can adopt the changes from 8442 here if you prefer that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get seth to submit that against release branch then? Pointless to do these edits redundantly.

Copy link
Collaborator

@j-berman j-berman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messaged @sethforprivacy about opening #8442 on the release branch too

EDIT: think this PR takes priority and the merge conflict will be easy enough to resolve

@sethforprivacy
Copy link
Contributor

I'll open #8442 against release branch today, sorry about that! Forgot that even doc changes need that.

@sethforprivacy
Copy link
Contributor

Done: #8491

@sethforprivacy
Copy link
Contributor

@selsta if you'd like, you can just drop your DOCKRUN.md changes and I'll bump mine to v0.18.1.0.

@luigi1111 luigi1111 merged commit dc2f548 into monero-project:release-v0.18 Aug 9, 2022
@selsta selsta deleted the prepare-v0.18.1.0 branch August 10, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants