Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitian: refresh submodules before compiling #8292

Closed

Conversation

mj-xmr
Copy link
Contributor

@mj-xmr mj-xmr commented Apr 26, 2022

Prevents symptoms such as:

Submodule 'external/miniupnp' is not up-to-date.

during performing "Reproducible Builds".

The problem lies in gitian-builder, where the submodule synchronisation is not done thoroughly:

system!("cd inputs/#{dir} && git submodule update --init --recursive --force")

Please compare with my version:

    system!("cd inputs/#{dir} && git submodule update --init --recursive --force")
    system!("cd inputs/#{dir} && git submodule update --remote")
    system!("cd inputs/#{dir} && git submodule sync")
    system!("cd inputs/#{dir} && git submodule update")

[EDIT]: A much less obtrusive alternative can be found here: #8296

@mj-xmr mj-xmr marked this pull request as draft April 26, 2022 07:18
@mj-xmr
Copy link
Contributor Author

mj-xmr commented Apr 28, 2022

Closing, since the equivalent #8296 is much simpler.

@mj-xmr mj-xmr closed this Apr 28, 2022
@mj-xmr mj-xmr deleted the gitian-refresh-submodules branch May 1, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant