Preserve commitment format inside transactions #8277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
j-berman
added a commit
to j-berman/monero-lws
that referenced
this pull request
Apr 27, 2022
This can be reverted once monero-project/monero#8277 is merged
moneromooo-monero
approved these changes
Apr 30, 2022
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change to the format commitment / 8 was included with BP+, which is a minor optimization which increased complexity, spread out where crypto code is handled, and created a disparate state between transactions and disk (as they were saved in their full form thanks to a processing step inside the DB code).
This PR reverts this planned change. The blockchain_db.cpp edits may look to be further edited than just this reversion, yet that was its code pre-BP+.