block_queue: faster check whether a block was requested #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coneiric
reviewed
Aug 26, 2018
| s.hashes = std::move(hashes); | ||
| for (const crypto::hash &h: s.hashes) | ||
| requested_hashes.insert(h); |
There was a problem hiding this comment.
Is this inserting hash references after they are invalidated in erase_block?
There was a problem hiding this comment.
Nice catch, but hashes is not a reference (parameter to the function).
coneiric
approved these changes
Aug 28, 2018
luigi1111
added a commit
that referenced
this pull request
Sep 4, 2018
704b60c block_queue: faster check whether a block was requested (moneromooo-monero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.