Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Haveno, removed Localmonero #2305

Closed

Conversation

ligix
Copy link

@ligix ligix commented Jun 1, 2024

Title is self explanatory, this PR replaces Localmonero with Haveno in Community > Merchants & Exchanges > P2P exchanges and Atomic Swaps.

Closes #2304

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for barolo-time-757cf9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e3f161b
🔍 Latest deploy log https://app.netlify.com/sites/barolo-time-757cf9/deploys/665b77005505070008ee2f8a
😎 Deploy Preview https://deploy-preview-2305--barolo-time-757cf9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Justxd22
Copy link

Justxd22 commented Jun 1, 2024

replace logo with svg [logo]

@ligix
Copy link
Author

ligix commented Jun 1, 2024

We should.consider leaving it up and displaying the above timeline for 6 months with the deletion coming after as this may help someone
~ plowsof

Looking at #2293, how should it be handled?

IMO if you want to keep linking Localmonero it may make sense to just push it to the bottom of the list since the roadmap is displayed prominently on the homepage of Localmonero.
It could also be grayed out / a warning could be shown in the description but at that point what's the point of keeping it linked?

Screenshot showing an alternate description for Localmonero which has "⚠️ Shuts down on November 7 2024 ⚠️" appended to it

@plowsof
Copy link
Collaborator

plowsof commented Jun 1, 2024

replace logo with svg [logo]

i thought we had established svg's should be replaced from getmonero freedomofpress/securedrop#1574 (comment)

@plowsof
Copy link
Collaborator

plowsof commented Jun 1, 2024

I also NACK at this moment in time for listing haveno.exchange on the merchants/p2p section. it's mostly info / a blog.

@ligix
Copy link
Author

ligix commented Jun 1, 2024

I also NACK at this moment in time for listing haveno.exchange on the merchants/p2p section. it's mostly info / a blog.

Sure, I'll close this until it's more mature.

@ligix ligix closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Haveno.exchange in P2P exchanges and Atomic Swaps and remove the localmonero
3 participants