AddressBook: fix index 0 description bug #3863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any reason for this being WIP? |
The address description in index 0 was being overwritten when a new address was added. Remove the erroneous else statement causing the issue.
|
@selsta was just testing some more, is open now. |
|
I added that code here: #3096 How does editing a description work now with it removed? (I'm on my phone currently otherwise I would check myself) |
selsta
reviewed
Mar 16, 2022
|
#3865 solved this issue for me, could you try it to confirm? :) |
checking, i was only doing add not edit |
|
fixed by #3865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes monero-project/monero#8218