Skip to content

Commit

Permalink
History: fix payment proof button
Browse files Browse the repository at this point in the history
Adding support for reserve proof added an additional
argument to the getProofClicked signal. The payment
proof button on the transaction list from history.qml
does not pass this argument and fails with insufficient
argument error.

Fixes: 0f67580 ("Advanced: ReserveProof: Add support for reserve proof")
  • Loading branch information
reemuru committed May 5, 2022
1 parent 002fe8e commit cddf3c3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion main.qml
Original file line number Diff line number Diff line change
Expand Up @@ -999,7 +999,7 @@ ApplicationWindow {

// called on "getProof"
function handleGetProof(txid, address, message, amount) {
if (amount.length > 0) {
if (amount !== null && amount.length > 0) {
var result = currentWallet.getReserveProof(false, currentWallet.currentSubaddressAccount, walletManager.amountFromString(amount), message)
txProofComputed(null, result)
} else {
Expand Down
2 changes: 1 addition & 1 deletion pages/History.qml
Original file line number Diff line number Diff line change
Expand Up @@ -1720,7 +1720,7 @@ Rectangle {
}

console.log("getProof: Generate clicked: txid " + hash + ", address " + address);
middlePanel.getProofClicked(hash, address, '');
middlePanel.getProofClicked(hash, address, '', null);
informationPopup.title = qsTr("Payment proof") + translationManager.emptyString;
informationPopup.text = qsTr("Generating payment proof") + "..." + translationManager.emptyString;
informationPopup.onCloseCallback = null
Expand Down

0 comments on commit cddf3c3

Please sign in to comment.