Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing output when scanning multiple K8s manifests by folder #238

Closed
tas50 opened this issue Dec 14, 2022 · 4 comments
Closed

Confusing output when scanning multiple K8s manifests by folder #238

tas50 opened this issue Dec 14, 2022 · 4 comments

Comments

@tas50
Copy link
Member

tas50 commented Dec 14, 2022

Describe the bug
When you provide cnspec with a directory to scan for manifests the output is not entirely clear.

 ~/dev  cnspec scan k8s lunalectric/
→ loaded configuration from /Users/tsmith/.config/mondoo/mondoo.yml using source default
→ using service account credentials
→ discover related assets for 1 asset(s)
→ discovery option auto is used. This will detect the assets: cluster, jobs, cronjobs, pods, statefulsets, deployments, replicasets, daemonsets
→ resolved assets resolved-assets=5
→ connecting to asset K8s Manifest lunalectric (code)

███████████████████████████████████████████████████████████████████████████ 100% K8s Manifest lunalectric
→ connecting to asset luna/postgres (k8s-object)

███████████████████████████████████████████████████████████████████████████ 100% luna/postgres
→ connecting to asset luna/luna-frontend (k8s-object)

███████████████████████████████████████████████████████████████████████████ 100% luna/luna-frontend
→ connecting to asset luna/postgres (k8s-object)

███████████████████████████████████████████████████████████████████████████ 100% luna/postgres
→ connecting to asset luna/luna-frontend (k8s-object)

███████████████████████████████████████████████████████████████████████████ 100% luna/luna-frontend

The start of the scan states K8s Manifest lunalectric when there is no actual manifest named lunalectric. lunalectric is the directory of manifests. We then proceed to provide a progress bar for this fictitious manifests which is confusing.

@czunker
Copy link
Contributor

czunker commented Jan 4, 2023

Would this be helpful?

→ resolved assets resolved-assets=2
→ connecting to asset K8s Manifest directory lunalectric (code)

███████████████████████████████████████████████████████████████████████████ 100% K8s Manifest directory lunalectric
→ connecting to asset luna/postgres (k8s-object)

███████████████████████████████████████████████████████████████████████████ 100% luna/postgres


Asset: K8s Manifest directory lunalectric

@chris-rock
Copy link
Member

There two issues here:

  1. Just having one progress bar
  2. Be more specific on the root object. I think it is definitely an improvement to call it "K8S Manifest directory"

@tas50
Copy link
Member Author

tas50 commented Jan 4, 2023

We have an opportunity to solve the progress bar problem, which is in the works

czunker added a commit to mondoohq/cnquery that referenced this issue Jan 5, 2023
czunker added a commit to mondoohq/cnquery that referenced this issue Jan 5, 2023
@chris-rock
Copy link
Member

I close this issue since it not a bug and its work is not tracked here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants