cnquery can read config file from aws ssm parameter store #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
changed the title
vjeffrey
force-pushed
the
vj/config-ssmparam
branch
3 times, most recently
from
d6b1eb5
to
0a00e08
Compare
vjeffrey
changed the title
arlimus
reviewed
Feb 16, 2023
cli/config/config.go
Outdated
| @@ -173,6 +173,17 @@ func initConfig() { | |||
| } else { | |||
| Source = "default" | |||
| } | |||
| if len(Path) > 0 { | |||
There was a problem hiding this comment.
nit: do we need to check len(Path) > 0? wouldn't the next statement suffice
There was a problem hiding this comment.
oh, good point, we can remove that
vjeffrey
force-pushed
the
vj/config-ssmparam
branch
from
0a00e08
to
72c4daf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cnspec can read the service account credentials stored in AWS ssm parameter store