Add enabled property for gcp.project.dataproc. Only query clusters if… #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service's enabled (#939) Fixes #938, the `DataProc Cloud` service can also be disabled for a project, which means we cannot fetch clusters from it. To fix this, I am adding an `enabled` field to the service and skipping clusters retrieval if the service is disabled: On a GCP with DataProc disabled ``` cnquery> gcp.project.dataproc.enabled [failed] gcp.project.dataproc.enabled expected: == true actual: false cnquery> gcp.project.dataproc.clusters ! DataProc Cloud API is not enabled, not querying clusters gcp.project.dataproc.clusters: [] ``` On a GCP with DataProc enabled ``` cnquery> gcp.project.dataproc.enabled [ok] value: true cnquery> gcp.project.dataproc.clusters gcp.project.dataproc.clusters: [] ``` We should probably do this for all GCP services since most of them can be disabled - [x] Test with a `cnspec scan`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… service's enabled (#939)
Fixes #938, the
DataProc Cloudservice can also be disabled for a project, which means we cannot fetch clusters from it. To fix this, I am adding anenabledfield to the service and skipping clusters retrieval if the service is disabled:On a GCP with DataProc disabled
On a GCP with DataProc enabled
We should probably do this for all GCP services since most of them can be disabled
cnspec scan