🧹 add a few more details to the ecs container assets discovered #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/more-ecs-info
branch
3 times, most recently
from
49c6d84
to
be42d25
Compare
vjeffrey
force-pushed
the
vj/more-ecs-info
branch
from
be42d25
to
1964a4e
Compare
joelddiaz
reviewed
Jan 31, 2023
Comment on lines
+266
to
+269
| ContainerName = "container_name" | ||
| ClusterNameLabel = "cluster_name" | ||
| TaskDefinitionArnLabel = "task_definition_arn" | ||
| TaskId = "task_id" |
There was a problem hiding this comment.
Didn't see where ContainerName and TaskId are used
There was a problem hiding this comment.
they will be used in the lambda/at ecs exec scan time
joelddiaz
approved these changes
Jan 31, 2023
vjeffrey
force-pushed
the
vj/more-ecs-info
branch
from
1964a4e
to
fb2cb9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of this information was missing for the scan time results of ecs containers