Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 remove num-assets cli argument #814

Merged
merged 1 commit into from
Jan 23, 2023
Merged

🧹 remove num-assets cli argument #814

merged 1 commit into from
Jan 23, 2023

Conversation

chris-rock
Copy link
Member

revert the accidental exposure of the progress bar settings in proto, introduced in #771

arlimus
arlimus approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! +1, we want to be careful with the CLI args we expose. I do think making it user-configurable in the future is helpful, but it should be hidden in the config somewhere and not cluttering up CLI args.

@arlimus arlimus merged commit 8df7086 into main Jan 23, 2023
@arlimus arlimus deleted the chris-rock/revert-progress-proto-change branch January 23, 2023 09:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arlimus arlimus arlimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @arlimus