-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ Add azure.subscription. Move all azure resources under azure.subscription #810
Conversation
This comment has been minimized.
This comment has been minimized.
ee30071
to
913853b
Compare
This does mean that when we introduce the individual assets (not sure if that's already present for Azure) you will face the following issue:
If you try to change |
b6552f7
to
1aec447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks similar to what we have for GCP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @preslavgerchev
…ription and aliases for backwards compatability.
…ure.subscription shows up as a suggestion.
- Add subscriptionId to all services and make identiiers unique to not have them clash between multiple subscriptions.
1aec447
to
e6d02fe
Compare
Introduce a new
azure.subscription
resource:All the resources are now moved from
azure.*
toazure.subscription.*
. This lets us build a resource hierarchy more clearly. Before:After:
There are aliases introduced to keep the old resources untouched to avoid breaking changes so
azure.compute.vms
will still work