Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 socketstats resource was returning an empty error #741

Merged
merged 1 commit into from
Jan 10, 2023
Merged

🧹 socketstats resource was returning an empty error #741

merged 1 commit into from
Jan 10, 2023

Conversation

chris-rock
Copy link
Member

when used on a povider that does not allow to run commands, it returned an empty error:

cnspec> socketstats.openPorts
Query encountered errors:

socketstats.openPorts: []

Not it returns:

cnspec> socketstats.openPorts
Query encountered errors:
socketStats not supported on this provider
socketstats.openPorts: []

@chris-rock chris-rock mentioned this pull request Jan 8, 2023
Closed
imilchev
imilchev approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chris-rock chris-rock merged commit 57bf6fc into main Jan 10, 2023
@chris-rock chris-rock deleted the fix-socketstats-error branch January 10, 2023 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imilchev imilchev imilchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-rock @imilchev