Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add azure.storage.account resources #714

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Jan 4, 2023

Adds the following new azure storage resources:

  • azure.storage.account.queueService.properties
  • azure.storage.account.blobService.properties
  • azure.storage.account.tableService.properties
  • azure.storage.account.dataProtection

@preslavgerchev preslavgerchev force-pushed the preslav/microsoft-cloud-resources branch 2 times, most recently from 09a2cdc to 6c07cce Compare January 5, 2023 08:58
@preslavgerchev preslavgerchev changed the title ✨ Azure Storage resources ✨ Add azure.storage.account resources Jan 5, 2023
@preslavgerchev preslavgerchev changed the base branch from preslav/microsoft-cloud-resources to main January 5, 2023 09:11
@preslavgerchev preslavgerchev force-pushed the preslav/azure-storage-resources branch 4 times, most recently from 9a0ae97 to 76945f7 Compare January 5, 2023 09:23
Copy link
Contributor

@misterpantz misterpantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preslavgerchev these descriptions are very clear and helpful! The only changes I suggested here are for consistency. Eventually all our auto-generated docs will be consistent. :)
Thanks so much for the opportunity to review!

resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
resources/packs/azure/azure.lr Outdated Show resolved Hide resolved
  - azure.storage.account.queueService.properties
  - azure.storage.account.blobService.properties
  - azure.storage.account.tableService.properties
  - azure.storage.account.dataProtection

Signed-off-by: Preslav <[email protected]>
@preslavgerchev preslavgerchev merged commit e96934b into main Jan 5, 2023
@preslavgerchev preslavgerchev deleted the preslav/azure-storage-resources branch January 5, 2023 23:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants