-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add azure.storage.account resources #714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/microsoft-cloud-resources
branch
2 times, most recently
from
January 5, 2023 08:58
09a2cdc
to
6c07cce
Compare
preslavgerchev
changed the title
✨ Azure Storage resources
✨ Add azure.storage.account resources
Jan 5, 2023
preslavgerchev
changed the base branch from
preslav/microsoft-cloud-resources
to
main
January 5, 2023 09:11
preslavgerchev
force-pushed
the
preslav/azure-storage-resources
branch
4 times, most recently
from
January 5, 2023 09:23
9a0ae97
to
76945f7
Compare
misterpantz
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@preslavgerchev these descriptions are very clear and helpful! The only changes I suggested here are for consistency. Eventually all our auto-generated docs will be consistent. :)
Thanks so much for the opportunity to review!
- azure.storage.account.queueService.properties - azure.storage.account.blobService.properties - azure.storage.account.tableService.properties - azure.storage.account.dataProtection Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/azure-storage-resources
branch
from
January 5, 2023 23:12
c11e913
to
fb03d78
Compare
Co-authored-by: Letha <[email protected]>
preslavgerchev
force-pushed
the
preslav/azure-storage-resources
branch
from
January 5, 2023 23:14
fb03d78
to
6b30cd3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following new azure storage resources: