Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 remove todo comments from docs #699

Merged
merged 2 commits into from
Jan 3, 2023
Merged

🧹 remove todo comments from docs #699

merged 2 commits into from
Jan 3, 2023

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Dec 30, 2022

Additionally:

  • 🐛 Fix field comments in gcp.lr : see commit messages

Fixes #598

@jaym jaym force-pushed the jdm/598 branch 2 times, most recently from 72d1200 to d40f003 Compare December 30, 2022 21:22
jaym and others added 2 commits January 3, 2023 09:59
You cannot put comments inline after the field name. The way the parser is
structured, it cannot see newlines. They get interpreted as comments for
the next field
@chris-rock chris-rock merged commit e0ec1be into main Jan 3, 2023
@chris-rock chris-rock deleted the jdm/598 branch January 3, 2023 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude comments that start in TODO from the docs generation
4 participants