⭐ Create AWS resource aws.ec2.instances {iamInstanceProfile} #4767
+385
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
tas50
reviewed
Oct 18, 2024
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
vjeffrey
reviewed
Oct 21, 2024
vjeffrey
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
this works well!
i would prefer if the instance profile was a real resource instead of a dict, i left a longer comment explaining my thinking, but putting my +1 here now in case we need this quickly - it does the job, i just think if we make it a real resource we'll avoid a little bit of rework later
|
+1 to having real resources vs. dicts. It makes for better auto completes and docs. Overall it's a better user experience even if it's more work for us. |
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
misterpantz
reviewed
Oct 24, 2024
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tas50
reviewed
Oct 25, 2024
Signed-off-by: Manuel Weber <[email protected]>
Signed-off-by: Manuel Weber <[email protected]>
|
Thank you all for your help on this @tas50 @misterpantz and especially @vjeffrey for walking me through her process ! Done some cleanup and fixed a little thing, think it's ready to go now.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following resource:
