Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 load features from config #4747

Merged
merged 1 commit into from
Oct 15, 2024
Merged

🐛 load features from config #4747

merged 1 commit into from
Oct 15, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Oct 14, 2024 •
edited
Loading

getFeatures was called before viper/cobra was initialized therefore skipping features

Setting features via env would still overwrite those from config

@github-actions GitHub Actions
Copy link
Contributor

Test Results

3 116 tests  ±0   3 115 ✅ ±0   1m 24s ⏱️ +4s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 9e80e6a. ± Comparison against base commit 5188404.

@imilchev imilchev merged commit 2b75fec into main Oct 15, 2024
15 checks passed
@imilchev imilchev deleted the mik/fix-load-features-from-config branch October 15, 2024 07:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imilchev imilchev imilchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slntopp @imilchev