✨ Add support for comma-separated values on the same key for EC2 tag filters #4742
+27
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4739
This adds the possibility of specifying comma-separated values for the same key in a include/exclude tag filter. Those filters can now be specified as follows:
and
We keep treating the filter as a single
key : value
so this is backwards compatible. We just expand the string value right before applying the filters.Note:
There is a quirk with how filters are applied. Comma-separated values on the same key are applied with a logical
OR
. If we specify 2 tag filters on different keys, they are applied with a logicalAND
.