Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ find device by trailing letters #4732

Merged
merged 22 commits into from
Oct 24, 2024
Merged

✨ find device by trailing letters #4732

merged 22 commits into from
Oct 24, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Oct 9, 2024 

Before Change
BenchmarkFindDevice-8           1000000000               0.0000609 ns/op               0 B/op          0 allocs/op

Naive
BenchmarkFindDevice-8           1000000000               0.0001089 ns/op               0 B/op          0 allocs/op

Optimised
BenchmarkFindDevice-8           1000000000               0.0000595 ns/op               0 B/op          0 allocs/op

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Test Results

3 122 tests  +6   3 121 ✅ +6   1m 20s ⏱️ -11s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 7c20e48. ± Comparison against base commit a1ff2b3.

♻️ This comment has been updated with latest results.

@preslavgerchev
Copy link
Contributor

@slntopp can you also rebase this to get the benching pipeline green?

@slntopp slntopp force-pushed the mik/find-device-by-trailing-letter branch from 4fe3ccb to 75fc53e Compare October 21, 2024 13:27
@slntopp slntopp force-pushed the mik/find-device-by-trailing-letter branch from 61ba6f0 to bca2715 Compare October 22, 2024 14:08
preslavgerchev
preslavgerchev approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@preslavgerchev preslavgerchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one @slntopp

providers/os/connection/snapshot/blockdevices.go Outdated Show resolved Hide resolved
@slntopp slntopp merged commit 1fb2db8 into main Oct 24, 2024
14 checks passed
@slntopp slntopp deleted the mik/find-device-by-trailing-letter branch October 24, 2024 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slntopp @preslavgerchev