-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ device manager: multi partition support #4719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slntopp
force-pushed
the
mik/device-manager/multi-partition
branch
from
October 8, 2024 11:06
3f5fa33
to
75eca72
Compare
slntopp
force-pushed
the
mik/device-manager/multi-partition
branch
from
October 8, 2024 11:33
75eca72
to
9be578c
Compare
slntopp
changed the title
device manager: multi partition support
⭐️ device manager: multi partition support
Oct 8, 2024
can we also verify this doesn't break current behaviour of the device connection? |
[ec2-user@ip-172-31-15-93 ~]$ sudo ./cnquery scan --inventory-file inventory.yaml --verbose --output=yaml 2>/dev/null 1> vmtdish.log
[ec2-user@ip-172-31-15-93 ~]$ sudo cnquery scan --inventory-file inventory.yaml --verbose --output=yaml 2>/dev/null 1> upstream.log
[ec2-user@ip-172-31-15-93 ~]$ diff vmtdish.log upstream.log
2,3c2,3
< //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb:
< mrn: //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb
---
> //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5:
> mrn: //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5
6c6
< //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb:
---
> //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5: inventory: spec:
assets:
- name: vmtd
platform_ids:
- //platformid.api.mondoo.app/runtime/google-cloud-vmtd/
connections:
- type: device
options:
device-name: /dev/sdz
mount-all-partitions: true
verbose: true |
slntopp
force-pushed
the
mik/device-manager/multi-partition
branch
from
October 9, 2024 09:53
0084f42
to
2c15311
Compare
preslavgerchev
approved these changes
Oct 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.