Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ device manager: multi partition support #4719

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Oct 7, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Test Results

3 114 tests  ±0   3 113 ✅ ±0   1m 30s ⏱️ +10s
  371 suites ±0       1 💤 ±0 
   28 files   ±0       0 ❌ ±0 

Results for commit 2c15311. ± Comparison against base commit 761f540.

♻️ This comment has been updated with latest results.

@slntopp slntopp force-pushed the mik/device-manager/multi-partition branch from 3f5fa33 to 75eca72 Compare October 8, 2024 11:06
@slntopp slntopp force-pushed the mik/device-manager/multi-partition branch from 75eca72 to 9be578c Compare October 8, 2024 11:33
@slntopp slntopp changed the title device manager: multi partition support ⭐️ device manager: multi partition support Oct 8, 2024
@slntopp slntopp marked this pull request as ready for review October 8, 2024 11:37
@preslavgerchev
Copy link
Contributor

can we also verify this doesn't break current behaviour of the device connection?

@slntopp
Copy link
Member Author

slntopp commented Oct 8, 2024

[ec2-user@ip-172-31-15-93 ~]$ sudo ./cnquery scan --inventory-file inventory.yaml --verbose --output=yaml 2>/dev/null 1> vmtdish.log
[ec2-user@ip-172-31-15-93 ~]$ sudo cnquery scan --inventory-file inventory.yaml --verbose --output=yaml 2>/dev/null 1> upstream.log
[ec2-user@ip-172-31-15-93 ~]$ diff vmtdish.log upstream.log 
2,3c2,3
<   //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb:
<     mrn: //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb
---
>   //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5:
>     mrn: //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5
6c6
<   //explorer.api.mondoo.com/assets/2nA7f5QahsmDZ7THearJtBAFrjb:
---
>   //explorer.api.mondoo.com/assets/2nA7gObNb6y08Wvh6VfdRmfuRN5:

inventory:

spec:
  assets:
  - name: vmtd
    platform_ids:
    - //platformid.api.mondoo.app/runtime/google-cloud-vmtd/
    connections:
    - type: device
      options:
        device-name: /dev/sdz
        mount-all-partitions: true
        verbose: true

@slntopp slntopp force-pushed the mik/device-manager/multi-partition branch from 0084f42 to 2c15311 Compare October 9, 2024 09:53
@slntopp slntopp merged commit af522ea into main Oct 9, 2024
14 of 15 checks passed
@slntopp slntopp deleted the mik/device-manager/multi-partition branch October 9, 2024 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants