Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix rpm parser #4391

Merged
merged 1 commit into from
Jul 22, 2024
Merged

🐛 fix rpm parser #4391

merged 1 commit into from
Jul 22, 2024

Conversation

chris-rock
Copy link
Member

@chris-rock chris-rock commented Jul 22, 2024

There was a bug in the generated commands. The tests returned the right results that is why they have not catched this case.

The problem was introduced in https://github.com/mondoohq/cnquery/pull/4334/files#diff-f2d1541558cf19abeed69cd85d78939d7a61c44ec541a10d2817bfc513637894

Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Test Results

3 079 tests  ±0   3 078 ✅ ±0   1m 33s ⏱️ -11s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit 5f82668. ± Comparison against base commit a2151b8.

@chris-rock chris-rock merged commit 4fbeba7 into main Jul 22, 2024
15 checks passed
@chris-rock chris-rock deleted the chris-rock/fix-rpm-parser branch July 22, 2024 22:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants