Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹🐛 Don't show private resources in the shell auto complete #4321

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

slntopp
Copy link
Member

@slntopp slntopp commented Jul 8, 2024

apparently private resources are still suggested in cnquery/cnspec shell

For example aws.ecs.instance is marked as private and shouldn't be accessible directly but only via aws.ecs.containerInstances

But here is what we can see:
Screenshot 2024-07-08 at 20 50 36

Same for lots of other resources.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

Test Results

3 073 tests  ±0   3 072 ✅ ±0   1m 34s ⏱️ +11s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit 61437af. ± Comparison against base commit bc3c52d.

@tas50 tas50 changed the title 🧹🐛 skip private packages in suggestions 🧹🐛 Don't show private resources in the shell auto complete Jul 8, 2024
@imilchev imilchev requested a review from jaym July 9, 2024 07:03
@tas50 tas50 merged commit d183262 into main Jul 9, 2024
14 of 15 checks passed
@tas50 tas50 deleted the mik/skip-private-resources-in-suggestions branch July 9, 2024 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants