Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Update deps for cnquery and providers 20240708 #4316

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 8, 2024

Created by Mondoo Tools via GitHub Actions

Workflow:
https://github.com/mondoohq/cnquery/actions/workflows/update-deps.yaml

@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 8, 2024
Copy link
Contributor Author

github-actions bot commented Jul 8, 2024

Test Results

3 073 tests  ±0   3 072 ✅ ±0   1m 26s ⏱️ +3s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit 914af9a. ± Comparison against base commit bc3c52d.

♻️ This comment has been updated with latest results.

@czunker czunker marked this pull request as draft July 8, 2024 08:45
@czunker
Copy link
Contributor

czunker commented Jul 8, 2024

Need to clarify whether we can update to modernc.org/libc v1.54.2

@czunker
Copy link
Contributor

czunker commented Jul 8, 2024

This still breaks the os provider release: https://github.com/mondoohq/cnquery/actions/runs/9836900484/job/27153597047 Thanks @preslavgerchev

We need to pin this version for now.

Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker force-pushed the version/deps_update_20240708_0821 branch from 4ef562b to 914af9a Compare July 11, 2024 08:30
@@ -4,9 +4,12 @@ go 1.22.0

toolchain go1.22.4

// Later versions break the build of the os provider for Windows
replace modernc.org/libc => modernc.org/libc v1.53.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@czunker czunker marked this pull request as ready for review July 11, 2024 09:39
@czunker czunker merged commit 7b2158a into main Jul 11, 2024
41 checks passed
@czunker czunker deleted the version/deps_update_20240708_0821 branch July 11, 2024 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants