⭐️ add subnets to rds db instances #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vjeffrey
commented
Jul 1, 2024
vjeffrey
commented
czunker
reviewed
Jul 4, 2024
providers/aws/resources/aws_rds.go
Outdated
| return res, nil | ||
| } | ||
| a.Subnets.State = plugin.StateIsNull | plugin.StateIsSet | ||
| return nil, nil |
There was a problem hiding this comment.
I'm wondering whether this should return an error.
I don't know this AWS service from personal use, so I skimmed over the docs. I found this one:
Your VPC must have a DB subnet group that you create.
Could it be possible we cannot access this data?
There was a problem hiding this comment.
oh, interesting, ill check 👍
There was a problem hiding this comment.
ya, it seems we should always have this info
czunker
approved these changes
Jul 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.