🐛 Safeguard GCP connection in gcp init resources.

[preslavgerchev]

No description provided.

[github-actions]

Test Results

3 071 tests  ±0   3 070 ✅ ±0   1m 23s ⏱️ +2s
  363 suites ±0       1 💤 ±0 
   27 files   ±0       0 ❌ ±0 

Results for commit 3bb4546. ± Comparison against base commit 4384e5d.

♻️ This comment has been updated with latest results.

[czunker]

Just curious: What happened that we need this now?

[czunker]

Should we extend this func to also return an error?

[preslavgerchev]

There are already code paths in the same func that return nil (when no matching platform exists) so I assume returning nil here would be ok too

[preslavgerchev]

Just curious: What happened that we need this now?

Using a GCP/Azure/AWS snapshot connection right now is a bit weird: We use the GCP provider and we return a file system connection. There are some query filters that do query GCP resources, e.g. gcp.organization.labels (this is a totally made up example). Since we're coming from an GCP provider, this query can be compiled so it will be tried. However, the connection underneath is not a GcpConnection so we get the panic. Long term I believe we want to fix this differently but that's a good fix for the time being

[czunker]

Just curious: What happened that we need this now?

Using a GCP/Azure/AWS snapshot connection right now is a bit weird: We use the GCP provider and we return a file system connection. There are some query filters that do query GCP resources, e.g. gcp.organization.labels (this is a totally made up example). Since we're coming from an GCP provider, this query can be compiled so it will be tried. However, the connection underneath is not a GcpConnection so we get the panic. Long term I believe we want to fix this differently but that's a good fix for the time being

Thanks for the explanation. That's really wired.