Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 ensure we always read the fine grained assets FF for AWS #4254

Merged
merged 2 commits into from
Jun 20, 2024
Merged

🧹 ensure we always read the fine grained assets FF for AWS #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be616a6
🧹 ensure we always read the fine grained assets FF for AWS
vjeffrey Jun 17, 2024
1a7f1c1
❓ why did the checksum for the azure query change? this is odd
vjeffrey Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mqlc/mqlc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ func TestCompiler_DeterministicChecksum(t *testing.T) {
azureConf := mqlc.NewConfig(azure_schema, features)
res, err := mqlc.Compile(mql, map[string]*llx.Primitive{}, azureConf)
require.Nil(t, err)
require.Equal(t, res.CodeV2.Id, "LkB8PP3xB2Q=")
require.Equal(t, res.CodeV2.Id, "h81H/YfoIRI=")
}
}

Expand Down
6 changes: 3 additions & 3 deletions providers/aws/resources/discovery.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,11 +222,11 @@ func Discover(runtime *plugin.Runtime, filters connection.DiscoveryFilters) (*in
}

func handleTargets(targets []string) []string {
if ENABLE_FINE_GRAINED_ASSETS {
return append(AllAPIResources, DiscoveryAccounts)
}
if len(targets) == 0 || stringx.Contains(targets, DiscoveryAuto) {
// default to auto if none defined
if ENABLE_FINE_GRAINED_ASSETS {
return AllAPIResources
}
return Auto
}

Expand Down
Loading