Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix gcp subnetwork navigation from gke resources #4251

Merged
merged 1 commit into from
Jun 18, 2024
Merged

🐛 fix gcp subnetwork navigation from gke resources #4251

merged 1 commit into from
Jun 18, 2024

Conversation

imilchev
Copy link
Member

Fixes #3871

czunker
czunker reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@czunker czunker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type mismatch is fixed.

But now, I get another error:

1 error occurred:
        * subnetwork not found

I tried this with our edge cluster, and there definitely is a subnet. I can see it in the Google console.

@imilchev
Copy link
Member Author

When running the GCP provider we need to use the project ID, not the project number as that is not working

czunker
czunker approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the project ID, it works.

@czunker czunker merged commit a87d381 into main Jun 18, 2024
15 checks passed
@czunker czunker deleted the ivan/gcp-subetwork-fix branch June 18, 2024 07:08
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@czunker czunker czunker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error fetching subnetwork of GKE cluster
2 participants
@imilchev @czunker