🧹 Use the registry directly to fetch Windows packages #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preslavgerchev
force-pushed
the
preslav/use-reg-keys
branch
from
ceb666b
to
e0c30d2
Compare
chris-rock
reviewed
Jun 6, 2024
preslavgerchev
force-pushed
the
preslav/use-reg-keys
branch
from
e0c30d2
to
2490e35
Compare
preslavgerchev
force-pushed
the
preslav/use-reg-keys
branch
from
2490e35
to
66d6887
Compare
afiune
reviewed
Jun 6, 2024
| continue | ||
| } | ||
| packages = append(packages, *p) | ||
| } |
There was a problem hiding this comment.
I have seen this same for loop in other places, I wonder if there is a way to abstract this later for two reasons:
- have a single place where we locate packages, so we don't have to update multiple functions
- use interfaces? so we can write some unit tests! 😄
There was a problem hiding this comment.
i dont think this is exactly what you meant here but: i pulled out the registry key -> package transformation into a separate function that is easily testable. we now fetch the children of the registry key and we pass them in so that the packageFromRegistryKey doesnt do any calls on its own. added tests too
afiune
reviewed
Jun 6, 2024
afiune
reviewed
Jun 6, 2024
| if displayName != "" && displayVersion != "" { | ||
| cpeWfn, err = cpe.NewPackage2Cpe(publisher, displayName, displayVersion, "", "") | ||
| if err != nil { | ||
| log.Debug().Err(err).Str("name", displayName).Str("version", displayVersion).Msg("could not create cpe for windows app package") |
There was a problem hiding this comment.
is this CPE optional? or why we don't error out here? 🤔
There was a problem hiding this comment.
I believe it is, yeah. Ive copied over the last implementation of how we fetch that.
afiune
reviewed
Jun 6, 2024
afiune
reviewed
Jun 6, 2024
afiune
approved these changes
Jun 6, 2024
preslavgerchev
force-pushed
the
preslav/use-reg-keys
branch
from
6b517fa
to
3d67cc2
Compare
Signed-off-by: Preslav <[email protected]>
preslavgerchev
force-pushed
the
preslav/use-reg-keys
branch
from
3d67cc2
to
a0b72fb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4203
Instead of running a powershell script, query the registry directly for the installed apps.