🧹 Add new methods for detecting and mounting in the volume mounter. #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reviously that was all done in one function, we now split those. Signed-off-by: Preslav <[email protected]>
preslavgerchev
commented
May 24, 2024
Test Results3 002 tests 3 001 ✅ 1m 31s ⏱️ Results for commit 87d7c46. ♻️ This comment has been updated with latest results. |
preslavgerchev
commented
May 24, 2024
vjeffrey
reviewed
May 24, 2024
vjeffrey
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the detection of the partition we're mounting from the actual mounting process. To not make any changes to existing code that's using the volume mounter, I've added two new functions there:
GetDeviceForMountingandMountP(artition)The device manager's interface was also reworked:
IdentifyBlockDevicetoIdentifyMountTargetsto better account for the fact we can have multiple targets (even if unimplemented)Mountnow returns the scan dir where it was mounted