🐛 ensure we scan all ecr images, do not rely on tags #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ecr-credential-helper library had tag based examples that we used when adding in the functionality. those aren't actually needed, we just need the full uri this changes to code to do that so we will no longer skip no-tag images
|
|
Test Results2 996 tests 2 995 ✅ 1m 20s ⏱️ Results for commit 29b679f. |
preslavgerchev
approved these changes
May 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the ecr-credential-helper library had tag based examples that we used when adding in the functionality. those aren't actually needed, we just need the full uri this changes to code to do that so we will no longer skip no-tag images