Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add PostgreSQL flexible servers as a resource. Azure discovery now includes MySQL and PostgreSQL flexible servers. #3994

Merged
merged 2 commits into from
May 15, 2024

Conversation

preslavgerchev
Copy link
Contributor

Add a new resource for PostgreSQL flexible servers.
As part of the fine-grained assets discovery, the provider now also discovers flexible mysql and postgresql servers.

…includes MySQL and PostgreSQL flexible servers.

Signed-off-by: Preslav <[email protected]>
Copy link
Contributor

github-actions bot commented May 15, 2024

Test Results

2 993 tests  ±0   2 992 ✅ ±0   1m 46s ⏱️ +15s
  329 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit 9ad3597. ± Comparison against base commit b22ac63.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-14_19:30:13.307683815_+0000_UTC_m=+0.009861116
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-14_19:30:13.307683815_+0000_UTC_m=+0.009861116
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-14_19:30:13.307683815_+0000_UTC_m=+0.009861116#01
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-14_15:14:05.434482859_+0000_UTC_m=+0.061524100
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-14_15:14:05.434482859_+0000_UTC_m=+0.061524100
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-14_15:14:05.434482859_+0000_UTC_m=+0.061524100#01

♻️ This comment has been updated with latest results.

@preslavgerchev preslavgerchev force-pushed the preslav/azure-fine-grained-new branch from 5f5d333 to e91cea0 Compare May 15, 2024 06:22
Copy link
Contributor

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vjeffrey vjeffrey merged commit 2f89c3c into main May 15, 2024
15 checks passed
@vjeffrey vjeffrey deleted the preslav/azure-fine-grained-new branch May 15, 2024 17:43
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
@tas50
Copy link
Member

tas50 commented May 15, 2024

@preslavgerchev I'm having a bit of trouble with the discover here. I created a flexible PG server and that shows up in the shell:

cnquery> azure.subscription.postgreSql.flexibleServers{*}
azure.subscription.postgreSql.flexibleServers: [
  0: {
    tags: {}
    properties: {
      availabilityZone: "2"
      backup: {
        backupRetentionDays: 7.000000
        earliestRestoreDate: "2024-05-15T22:00:38.2908597Z"
        geoRedundantBackup: "Disabled"
      }

but when I try the discovery nothing is found:

 ~/dev  cnspec scan azure --discover postgres-servers --config ~/Downloads/edge-default.json
→ loaded configuration from /Users/tsmith/Downloads/edge-default.json using source --config
→ using service account credentials
→ discover related assets for 1 asset(s)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants