⭐️ inventory template support #3940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/inventory-template
branch
2 times, most recently
from
6f2bc2a
to
109bf5b
Compare
chris-rock
commented
May 8, 2024
| @@ -214,16 +214,12 @@ func getCobraScanConfig(cmd *cobra.Command, runtime *providers.Runtime, cliRes * | |||
| config.DisplayUsedConfig() | |||
|
|
|||
| props := viper.GetStringMapString("props") | |||
| annotations := viper.GetStringMapString("annotation") | |||
There was a problem hiding this comment.
the binding was wrong, so this never worked before
| // for all assets | ||
| _ = viper.BindPFlag("incognito", cmd.Flags().Lookup("incognito")) | ||
| _ = viper.BindPFlag("insecure", cmd.Flags().Lookup("insecure")) | ||
| _ = viper.BindPFlag("querypacks", cmd.Flags().Lookup("querypack")) | ||
| _ = viper.BindPFlag("sudo.active", cmd.Flags().Lookup("sudo")) | ||
| _ = viper.BindPFlag("record", cmd.Flags().Lookup("record")) | ||
| // NOTE: we may "annotation" to "annotations" to align it with the internal config struct | ||
| _ = viper.BindPFlag("annotations", cmd.Flags().Lookup("annotation")) |
There was a problem hiding this comment.
required since the options use "annotations"
chris-rock
force-pushed
the
chris-rock/inventory-template
branch
from
109bf5b
to
2e5bf05
Compare
Test Results2 985 tests +1 2 984 ✅ +1 1m 19s ⏱️ -5s Results for commit 2e5bf05. ± Comparison against base commit 3a2bb65. This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cnquery is used in CI/CD pipelines, users want to leverage the inventory file which allows a lot of pre-configuration. If you want to scan different assets for different environments you also want to re-use the same template but allow some custom variables so that usage in CI/CD is easier. This PR introduces inventory templates. Just define a template and use the
getenvfunction to access environment variables:This inventory can now be used as following: