✨ aws ec2 eips, vpc natgateways, vpc peering conn, service endpoints #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
czunker
reviewed
May 8, 2024
| publicIp string | ||
| // false if allocationId not present | ||
| attached bool | ||
| // Ec2 instance associated with the EIP |
There was a problem hiding this comment.
I'm not that familiar with AWS. Can an EIP only be attached to an EC2 instance. Not something else?
There was a problem hiding this comment.
seems like it from looking at the api
| @@ -102,6 +104,128 @@ func (a *mqlAws) getVpcs(conn *connection.AwsConnection) []*jobpool.Job { | |||
| return tasks | |||
| } | |||
|
|
|||
| func (a *mqlAwsVpcNatgatewayAddress) id() (string, error) { | |||
| return a.AllocationId.Data, nil | |||
There was a problem hiding this comment.
Can a NAT GW IP not be assigned and this empty?
There was a problem hiding this comment.
oh, yup, nice catch, modifying this
czunker
approved these changes
May 8, 2024
misterpantz
reviewed
May 8, 2024
Co-authored-by: Letha <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.