Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Replace fsconn with local connection for docker files, allow running commands #3889

Merged
merged 2 commits into from
May 7, 2024

Conversation

preslavgerchev
Copy link
Contributor

Fixes #3813

  • Replace the FS conn with a local connection as we need this to able to fully resolve the docker file's properties (such as the owner).
  • Inject the local OS's family into the dockerfile asset to help the local connection run the right commands to be able to fetch users
  • Improve error messages that come from the users manager

@preslavgerchev preslavgerchev changed the title 🐛 Replace fsconn with local connection for docker files, 🐛 Replace fsconn with local connection for docker files, allow running commands Apr 30, 2024
Copy link
Contributor

github-actions bot commented Apr 30, 2024

Test Results

2 984 tests  ±0   2 983 ✅ ±0   1m 26s ⏱️ -1s
  329 suites ±0       1 💤 ±0 
   23 files   ±0       0 ❌ ±0 

Results for commit f350194. ± Comparison against base commit 3fd1be3.

♻️ This comment has been updated with latest results.

@preslavgerchev preslavgerchev merged commit 3a2bb65 into main May 7, 2024
15 checks passed
@preslavgerchev preslavgerchev deleted the preslav/3813 branch May 7, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in docker.file.file
3 participants